Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniz_export.h not found? #152

Open
AndreaSignori opened this issue Mar 24, 2020 · 4 comments
Open

miniz_export.h not found? #152

AndreaSignori opened this issue Mar 24, 2020 · 4 comments

Comments

@AndreaSignori
Copy link

I've cloned the repository, and linked it in my project, when i compile i'm getting "miniz_export not found" error. (I've checked and there's no such file in the repository)

@wdconinc
Copy link
Contributor

Your issue seems addressed by https://github.com/richgel999/miniz/blob/master/readme.md#Usage

Please use the files from the releases page in your projects. Do not use the git checkout directly! The different source and header files are amalgamated into one miniz.c/miniz.h pair in a build step (amalgamate.sh). Include miniz.c and miniz.h in your project to use Miniz.

@shuax
Copy link

shuax commented Jul 20, 2020

git submodule is not convenient to use

@michaeladamkatz
Copy link

Your issue seems addressed by https://github.com/richgel999/miniz/blob/master/readme.md#Usage

Please use the files from the releases page in your projects. Do not use the git checkout directly! The different source and header files are amalgamated into one miniz.c/miniz.h pair in a build step (amalgamate.sh). Include miniz.c and miniz.h in your project to use Miniz.

This doesn't help if you need a fix that is not yet part of an official release.

@ell1e
Copy link
Contributor

ell1e commented Nov 26, 2023

You just need to run amalgamate.sh if you get the dev version, then copy the resulting miniz.c and miniz.h files from inside the amalgamation subfolder that is created. Those correspond to the baked full versions. Please note sadly amalgamate.sh can break trying elaborate tests needlessly which I'm trying to address with a pull request but it's not in yet, so currently not only do you need cmake to assemble it but also you'll need clang and gcc and libsanitize and such around, and on platforms where libsanitize doesn't fully work (e.g. musl libc Linux, and who knows about Windows) you may be out of luck. If the pull request gets merged at some point, just cmake should be enough I hope. But e.g. inside a standard x64 Linux glibc docker container, a pretty widely available build environment on most Continuous Integration build service stuff, it should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants