From ba9b922cb8c5fd60efb2b273e351efa69515a0e5 Mon Sep 17 00:00:00 2001 From: rickstaa Date: Fri, 10 Dec 2021 16:45:16 +0100 Subject: [PATCH] style: cleanup code base --- .../effort_joint_trajectory_controllers.yaml | 24 +-- .../moveit_ros_control_gripper.yaml | 1 - ...position_joint_trajectory_controllers.yaml | 16 +- panda_gazebo/launch/load_controllers.launch | 58 +++---- ...effort_joint_trajectory_controllers.launch | 14 +- .../load_joint_effort_controllers.launch | 14 +- .../load_joint_position_controllers.launch | 14 +- ...sition_joint_trajectory_controllers.launch | 14 +- panda_gazebo/launch/panda_rviz.launch | 28 ++-- panda_gazebo/launch/put_robot_in_world.launch | 157 +++++++++--------- .../launch/start_pick_and_place_world.launch | 24 +-- panda_gazebo/launch/start_push_world.launch | 24 +-- panda_gazebo/launch/start_reach_world.launch | 24 +-- panda_gazebo/launch/start_simulation.launch | 44 ++--- panda_gazebo/launch/start_slide_world.launch | 24 +-- panda_gazebo/launch/start_world.launch | 25 +-- 16 files changed, 253 insertions(+), 252 deletions(-) diff --git a/panda_gazebo/cfg/controllers/effort_joint_trajectory_controllers.yaml b/panda_gazebo/cfg/controllers/effort_joint_trajectory_controllers.yaml index ff9aa037..632509fe 100644 --- a/panda_gazebo/cfg/controllers/effort_joint_trajectory_controllers.yaml +++ b/panda_gazebo/cfg/controllers/effort_joint_trajectory_controllers.yaml @@ -1,6 +1,6 @@ # Configuration file that contains the configuration values for setting up the panda # trajectory controllers that can control a joint effort hardware interface -panda_arm_controller: +effort_joint_trajectory_controller: type: effort_controllers/JointTrajectoryController joints: - panda_joint1 @@ -10,16 +10,6 @@ panda_arm_controller: - panda_joint5 - panda_joint6 - panda_joint7 - constraints: - goal_time: 0.5 - stopped_velocity_tolerance: 0 # Added because of wrong PID gains see #9 - panda_joint1: { goal: 0.05 } - panda_joint2: { goal: 0.05 } - panda_joint3: { goal: 0.05 } - panda_joint4: { goal: 0.05 } - panda_joint5: { goal: 0.05 } - panda_joint6: { goal: 0.05 } - panda_joint7: { goal: 0.05 } gains: panda_joint1: { p: 600, d: 30, i: 0.0 } panda_joint2: { p: 600, d: 30, i: 0.0 } @@ -27,4 +17,14 @@ panda_arm_controller: panda_joint4: { p: 600, d: 30, i: 0.0 } panda_joint5: { p: 250, d: 10, i: 0 } panda_joint6: { p: 150, d: 10, i: 0 } - panda_joint7: { p: 50, d: 5, i: 0 } \ No newline at end of file + panda_joint7: { p: 50, d: 5, i: 0 } + constraints: + goal_time: 0.5 + stopped_velocity_tolerance: 0 # Added because of wrong PID gains see #9 + panda_joint1: { goal: 0.005 } + panda_joint2: { goal: 0.005 } + panda_joint3: { goal: 0.005 } + panda_joint4: { goal: 0.005 } + panda_joint5: { goal: 0.005 } + panda_joint6: { goal: 0.005 } + panda_joint7: { goal: 0.005 } diff --git a/panda_gazebo/cfg/controllers/moveit_ros_control_gripper.yaml b/panda_gazebo/cfg/controllers/moveit_ros_control_gripper.yaml index a105c4d7..2fffdc62 100644 --- a/panda_gazebo/cfg/controllers/moveit_ros_control_gripper.yaml +++ b/panda_gazebo/cfg/controllers/moveit_ros_control_gripper.yaml @@ -20,4 +20,3 @@ move_group: default: true joints: - panda_finger_joint1 - - panda_finger_joint2 diff --git a/panda_gazebo/cfg/controllers/position_joint_trajectory_controllers.yaml b/panda_gazebo/cfg/controllers/position_joint_trajectory_controllers.yaml index 0042189a..5f2ebfd8 100644 --- a/panda_gazebo/cfg/controllers/position_joint_trajectory_controllers.yaml +++ b/panda_gazebo/cfg/controllers/position_joint_trajectory_controllers.yaml @@ -1,6 +1,6 @@ # Configuration file that contains the configuration values for setting up the panda # trajectory controllers -panda_arm_controller: +position_joint_trajectory_controller: type: position_controllers/JointTrajectoryController joints: - panda_joint1 @@ -12,10 +12,10 @@ panda_arm_controller: - panda_joint7 constraints: goal_time: 0.5 - panda_joint1: { goal: 0.05 } - panda_joint2: { goal: 0.05 } - panda_joint3: { goal: 0.05 } - panda_joint4: { goal: 0.05 } - panda_joint5: { goal: 0.05 } - panda_joint6: { goal: 0.05 } - panda_joint7: { goal: 0.05 } \ No newline at end of file + panda_joint1: { goal: 0.005 } + panda_joint2: { goal: 0.005 } + panda_joint3: { goal: 0.005 } + panda_joint4: { goal: 0.005 } + panda_joint5: { goal: 0.005 } + panda_joint6: { goal: 0.005 } + panda_joint7: { goal: 0.005 } \ No newline at end of file diff --git a/panda_gazebo/launch/load_controllers.launch b/panda_gazebo/launch/load_controllers.launch index 49f025b6..4c9f7f26 100644 --- a/panda_gazebo/launch/load_controllers.launch +++ b/panda_gazebo/launch/load_controllers.launch @@ -1,37 +1,37 @@ - - - - - + + + + + - - - - - - - - + + + + + + + + - - - - - + + + + - - - - - - - - - - - + + + + + + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/load_effort_joint_trajectory_controllers.launch b/panda_gazebo/launch/load_effort_joint_trajectory_controllers.launch index 8e5466b3..60fa9d74 100755 --- a/panda_gazebo/launch/load_effort_joint_trajectory_controllers.launch +++ b/panda_gazebo/launch/load_effort_joint_trajectory_controllers.launch @@ -1,13 +1,13 @@ - + - - + + - - - + + + - + \ No newline at end of file diff --git a/panda_gazebo/launch/load_joint_effort_controllers.launch b/panda_gazebo/launch/load_joint_effort_controllers.launch index c10ead6e..aaf66ad0 100755 --- a/panda_gazebo/launch/load_joint_effort_controllers.launch +++ b/panda_gazebo/launch/load_joint_effort_controllers.launch @@ -1,13 +1,13 @@ - + - - + + - - - - + + \ No newline at end of file diff --git a/panda_gazebo/launch/load_joint_position_controllers.launch b/panda_gazebo/launch/load_joint_position_controllers.launch index f400d382..b375772d 100755 --- a/panda_gazebo/launch/load_joint_position_controllers.launch +++ b/panda_gazebo/launch/load_joint_position_controllers.launch @@ -1,13 +1,13 @@ - + - - + + - - - - + + \ No newline at end of file diff --git a/panda_gazebo/launch/load_position_joint_trajectory_controllers.launch b/panda_gazebo/launch/load_position_joint_trajectory_controllers.launch index 35c98d76..0780204b 100755 --- a/panda_gazebo/launch/load_position_joint_trajectory_controllers.launch +++ b/panda_gazebo/launch/load_position_joint_trajectory_controllers.launch @@ -1,12 +1,12 @@ - + - - + + - - - - + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/panda_rviz.launch b/panda_gazebo/launch/panda_rviz.launch index 631321e4..86e4fea9 100755 --- a/panda_gazebo/launch/panda_rviz.launch +++ b/panda_gazebo/launch/panda_rviz.launch @@ -1,18 +1,18 @@ - - - - - - - - - - + + + + + + + + + + - - - - + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/put_robot_in_world.launch b/panda_gazebo/launch/put_robot_in_world.launch index a3655ae1..2a382c0b 100644 --- a/panda_gazebo/launch/put_robot_in_world.launch +++ b/panda_gazebo/launch/put_robot_in_world.launch @@ -1,90 +1,89 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + - - - + + + - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + - - - - - - - - - - + + + + + + + + + + - - + + - - - - - - + + + + + + - - - - - - + + + + + + - - - - + + + + - - - - - - + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/start_pick_and_place_world.launch b/panda_gazebo/launch/start_pick_and_place_world.launch index 717bb8d4..fefb129c 100644 --- a/panda_gazebo/launch/start_pick_and_place_world.launch +++ b/panda_gazebo/launch/start_pick_and_place_world.launch @@ -1,16 +1,16 @@ - - - - - + + + + + - - - - - - - + + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/start_push_world.launch b/panda_gazebo/launch/start_push_world.launch index 817909a5..8c07c6f8 100644 --- a/panda_gazebo/launch/start_push_world.launch +++ b/panda_gazebo/launch/start_push_world.launch @@ -1,16 +1,16 @@ - - - - - + + + + + - - - - - - - + + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/start_reach_world.launch b/panda_gazebo/launch/start_reach_world.launch index e9a3dddc..5d73d92b 100644 --- a/panda_gazebo/launch/start_reach_world.launch +++ b/panda_gazebo/launch/start_reach_world.launch @@ -1,16 +1,16 @@ - - - - - + + + + + - - - - - - - + + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/start_simulation.launch b/panda_gazebo/launch/start_simulation.launch index 38f65c3e..2739a3ef 100755 --- a/panda_gazebo/launch/start_simulation.launch +++ b/panda_gazebo/launch/start_simulation.launch @@ -1,26 +1,28 @@ - - - - - - - - - + + + + + + + + + + - - - - - - + + + + + + + - - - - - - + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/start_slide_world.launch b/panda_gazebo/launch/start_slide_world.launch index 5d665d72..1aaa1d50 100644 --- a/panda_gazebo/launch/start_slide_world.launch +++ b/panda_gazebo/launch/start_slide_world.launch @@ -1,16 +1,16 @@ - - - - - + + + + + - - - - - - - + + + + + + + \ No newline at end of file diff --git a/panda_gazebo/launch/start_world.launch b/panda_gazebo/launch/start_world.launch index a414c023..b4db3500 100644 --- a/panda_gazebo/launch/start_world.launch +++ b/panda_gazebo/launch/start_world.launch @@ -1,16 +1,17 @@ - - - - - + + + + + - - - - - - - + + + + + + + + \ No newline at end of file