New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 46 #47

Open

neurolabusc wants to merge 2 commits into master from issue46

Collaborator

neurolabusc commented Jan 20, 2025

Fixes #46.

Int64 values were read as 8 × int8, rather than 8 × uint8. Any value greater than 127 caused an overflow.
Int64 values did not correctly read sign.
Int64 values ignored littleEndian so failed for big-endian data.
The reader name has been changed from getLongAt() to getInt64At() to be explicit (in C longs are only ≥32 bits).

neurolabusc added 2 commits

January 20, 2025 09:47


          Minimal fix (#46)

8147c42


          Comprehensive fix (#46)

f9d2ade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet