Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can this be made better? Suggestions Please 🙂 #4

Open
rimijoker opened this issue Oct 13, 2020 · 9 comments
Open

How can this be made better? Suggestions Please 🙂 #4

rimijoker opened this issue Oct 13, 2020 · 9 comments
Labels
good first issue Good for newcomers hacktoberfest For hacktoberfest hacktoberfest2020 question Further information is requested

Comments

@rimijoker
Copy link
Owner

rimijoker commented Oct 13, 2020 •
edited
Loading

Suggestions Please 🙂

What new features can we add?
Any changes that can be made?
@rimijoker rimijoker added good first issue Good for newcomers question Further information is requested hacktoberfest For hacktoberfest hacktoberfest2020 labels Oct 13, 2020
@Aldhanekaa
Copy link

It would be cool if there are window controls and improvement in colors.
probably this would be cool feature!
Screen Shot 2020-10-13 at 21 18 40

@rimijoker
Copy link
Owner Author

It would be cool if there are window controls and improvement in colors.
probably this would be cool feature!
Screen Shot 2020-10-13 at 21 18 40

Thanks for your suggestion but I don't think adding window colours would be useful as it might confuse visitors.
For different/better colour options I think if we can provide some pre-loaded themes which can be easily switched, that would be really nice, can we do that?

@sonylomo
Copy link
Contributor

Hey, what about a light theme button?

@rimijoker
Copy link
Owner Author

Hey, what about a light theme button?

That would be great, a button to switch light/dark theme and an option to set a light theme or dark theme by default.

@amankrx
Copy link

amankrx commented Oct 16, 2020

How about adding a feature similar to hackertyper website.

@rimijoker
Copy link
Owner Author

How about adding a feature similar to hackertyper website.

What's that? :)

@sonylomo sonylomo mentioned this issue Nov 2, 2020
Merged
@sonylomo
Copy link
Contributor

sonylomo commented Nov 2, 2020

@rimijoker, I've tried implementing the Light Theme feature. Tell me what you think.😎

@rimijoker
Copy link
Owner Author

@rimijoker, I've tried implementing the Light Theme feature. Tell me what you think.

@sonylomo also try changing the bg colour to a lighter colour.

@sonylomo
Copy link
Contributor

sonylomo commented Nov 5, 2020

I'll work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest For hacktoberfest hacktoberfest2020 question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sonylomo @rimijoker @amankrx @Aldhanekaa