Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zdinx ACT #19

Open
13 tasks
jjscheel opened this issue Mar 17, 2023 · 16 comments
Open
13 tasks

Zdinx ACT #19

jjscheel opened this issue Mar 17, 2023 · 16 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 17, 2023

Technical Group

Architecture Test SIG

ratification-pkg

Zdinx

Technical Liaison

Allen Baum

Task Category

Arch Tests

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

3Q2023

Statement of Work (SOW)

Component names:

Requirements:
(prose describing what has to be done and what the end result is)

Deliverables:

  • Component 1 and changes expected.
  • Component 2 and changes expected.
    ...

Acceptance Criteria:

  • Component 1 and measured result.
  • Component 2 and measured result.
    ...

Projected timeframe: (best guess date)

SOW Signoffs: (delete those not needed)

  • Task group liaison sign-off date:
  • Development partner sign-off date:
  • ACT SIG sign-off date (if ACT work):
  • Toolchains & Runtimes sign-off date (if gcc, LLVM, binutils, gdb work):
  • Privileged SW HC sign-off date (if QEMU, KVM, kernel, or OS work):
  • Application & Tools HC sign-off date (if POC or toolchain/library work):

Waiver

  • Freeze
  • Ratification

Pull Request Details

@jjscheel jjscheel self-assigned this Mar 17, 2023
@jjscheel jjscheel moved this from As-planned to Blocked in RISC-V DevPartner Work Mar 17, 2023
@ptprasanna ptprasanna moved this from Blocked to As-planned in RISC-V DevPartner Work Jul 7, 2023
@ptprasanna ptprasanna assigned ptprasanna and unassigned jjscheel Jul 7, 2023
@jjscheel
Copy link
Contributor Author

Before we get started on this, I'd like to make sure we complete the SOW. @ptprasanna, can you propose some text and place in a comment for review?

@ptprasanna
Copy link

Majority of the codes changes are done as part of Zfinx, so have to check the double precision floating tests on integer registers, which are expected to run on the current code changes (Through the PR is merged yet), may require a minor fixes on the framework with respect to "ISAC" and "CTG". Bit of a test driven changes we may have to carry ahead.

@ptprasanna
Copy link

ptprasanna commented Sep 12, 2023

All the work related to Zdinx are completed with 100% coverage, now peer reviewing the reports. Also this has a dependency with the previous PR (zfh and zfinx) to be merged before raising a new PR for this work.

@anuani21
Copy link

Coverage Report for RV32Zdinx are placed in the below link:

https://gitlab.com/ptprasanna/actreports/-/tree/main/RV32Zdinx?ref_type=heads

Coverage Reports for RV64Zdinx are placed in the below link:

https://gitlab.com/ptprasanna/actreports/-/tree/main/RV64Zdinx?ref_type=heads

@jjscheel
Copy link
Contributor Author

jjscheel commented Sep 12, 2023

Would you kindly provide a link to the PR(s) being reviewed for this? Nevermind....

@jjscheel
Copy link
Contributor Author

@ptprasanna, I would like an update in the issue, by the next meeting on December 12, 2023, please.

@anuani21
Copy link

anuani21 commented Jan 8, 2024

All the work related to Zdinx are completed with 100% coverage reports. This has a dependency with the previous PR (zfh and zfinx).

Zfinx and Zfh PR for ISAC has been merged.
riscv-software-src/riscv-isac#72

Zfinx and Zfh PR from CTG has been waiting for review.
riscv-software-src/riscv-ctg#67

Previous PR(Zfinx and Zfh) to be merged before raising a new PR for this work.

@anuani21
Copy link

anuani21 commented Apr 2, 2024

@jjscheel,

Once Zfinx and Zfh PR from CTG has merged, I will raise a PR for Zdinx ACT.

@jjscheel
Copy link
Contributor Author

jjscheel commented Apr 2, 2024

Understand.

@allenjbaum, waiting here too.

@jjscheel jjscheel moved this from As-planned to Blocked in RISC-V DevPartner Work Apr 3, 2024
@jjscheel
Copy link
Contributor Author

@anuani21, I know that we are waiting for the PR in #17 and #18 to be accepted before building this PR. Given that we continue to wait for something, would it be worth our time to at least build this PR (assuming acceptance of the Zfinx and Zfh work) and submit for comment? Then, we could simply declare this "done" (or permanently blocked) and move on.

@ptprasanna ptprasanna moved this from Blocked to As-planned in RISC-V DevPartner Work Sep 19, 2024
@anuani21
Copy link

anuani21 commented Oct 1, 2024

@jjscheel,

Updates from IITM,

I have a raised a PR for Zdinx extension

  1. Riscv-ctg : Add support for Zdinx extension riscv-software-src/riscv-ctg#124
  2. Riscv-isac: Add support for Zdinx extension riscv-software-src/riscv-isac#101
  3. Riscv-arch-test: [ACT] [CTG] [ISAC] Add support Zdinx extension riscv-non-isa/riscv-arch-test#499

@jjscheel
Copy link
Contributor Author

jjscheel commented Oct 1, 2024

Thanks! I've updated the description above to include PRs.

@anuani21
Copy link

@jjscheel,

Updates from IITM,

Re-submiited the PR in riscv-ctg and riscv-isac into riscv-arch-test riscv-non-isa/riscv-arch-test#499

@anuani21
Copy link

@jjscheel,

Zdinx PR is still under review.

@anuani21
Copy link

@jjscheel,

Zdinx PR is still under review.

@jjscheel
Copy link
Contributor Author

@UmerShahidengr, any outlook for approval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: As-planned
Development

No branches or pull requests

3 participants