Spike submodule needs to be bumped?

[TommyMurphyTM1234]

Does it need to be bumped?
The one that gets built via the current submodule causes the debug tests to fail because it does not support this option in the latest Spike repo:

• https://github.com/riscv-software-src/riscv-isa-sim/blob/71f5a8fd1b1185b7c15151f116aa3fef058bf210/spike_main/spike.cc#L80

For more details see here:

• Passing and failing riscv-tests/debug on v0.11 - request for confirmation riscv-openocd#869 (comment)

[TommyMurphyTM1234]

While I'm at it, I'll flag this issue here again:

• bump gcc to 13.1 release #1239 (comment)

As mentioned there, it seems to me that the .gitmodules file has no effect.
In the case of Spike it currently says:

• riscv-gnu-toolchain/.gitmodules

  Line 34 in 6da3855

  branch = master

[submodule "spike"]
	path = spike
	url = https://github.com/riscv-software-src/riscv-isa-sim.git
	branch = master

Which would make one assume that building the riscv-gnu-toolchain would always fetch and build the latest master branch from the Spike repo. This is not the case as it is the commit specified here which is fetched instead:

git clone https://github.com/riscv-collab/riscv-gnu-toolchain
cd riscv-gnu-toolchain
git submodule

-b2bc62b7b4e7638c3a249d2d2728ceb4d5f2b22c binutils
-c298959ef991b389b64a825f70094738c6a48780 dejagnu
-2ee5e4300186a92ad73f1a1a64cb918dc76c8d67 gcc
-e53a8e8685685c97588f8319d993ea6cd5635e47 gdb
-a704fd9a133bfb10510e18702f48a6a9c88dbbd5 glibc
-185b81e034ba60081023b6e59504dfffb560f3e3 llvm
-85e0e3519655220688e757b9d5bfd314923548bd musl
-415fdd4279b85eeec9d54775ce13c5c412451e08 newlib
-2efabd3e6604b8a9e8f70baf52f57696680c7855 pk
-621da7789083b80d6f1ff1c0fb499334007b4f51 qemu
-a0298a33e7b2091ba8d9f3a20838d96dc1164cac spike

The use of this "pinned" commit is also reflected in the GitHub view of the riscv-gnu-toolchain repo:

As such, it seems again to me that the .gitmodules file is either redundant or is not always being used to determine what exactly is retrieved for each submodule.

[TommyMurphyTM1234]

Addressed by #1283