Revert "target/riscv: Reject size 2 soft breakpoints when C extension not supported" #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMatCodasip
approved these changes
Oct 23, 2023
timsifive
deleted the
revert-908-disable-soft-bp-size-2-non-compressed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #908.
This change causes issues because it's not completely clear whether misa.C must be set if Zc* is implemented. (riscvarchive/riscv-code-size-reduction#228 (comment) suggests it might be required, but the specs themselves aren't clear enough about it.)
Potentially we could test c.nop in examine() (#908 (comment)). But let's get OpenOCD back to full functionality soon, and then maybe we can reintroduce this change in a more robust way.