target/riscv: Handle sbbusyerror in read_memory_bus_v1 #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be able to take a closer look Friday morning. |
JanMatCodasip
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
I have checked this change visually. The fixes look all right to me, thank you.
@timsifive Do I understand correctly that you aim to add some sort of "system bus stress mode" into Spike?
The existing code didn't seem to work right at all. I have spike modifications that exercise these new cases. I'll merge those once this has merged. Change-Id: I89bd336f34f1b208a76f25b6b41fe3877800765b Signed-off-by: Tim Newsome <[email protected]>
timsifive
force-pushed
the
sbbusyerror
branch
from
9b160da to
08182bf
Compare
JanMatCodasip
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code didn't seem to work right at all. I have spike modifications that exercise these new cases. I'll merge those once this has merged.
Maybe this helps with #880.
Change-Id: I89bd336f34f1b208a76f25b6b41fe3877800765b