Suggest behavior of ERR_MFR.svi is WARL and bit width of MDCFGLCK.f is 6 #26
Conversation
Change behavior of ERR_MFR.svi from RW to WARL. Change bit width of MDCFGLCK.f. Signed-off-by: tyshyu <[email protected]>
Signed-off-by: tyshyu <[email protected]>
| @@ -333,7 +333,7 @@ h|Field |Bits |R/W |Default |Description | |||
| 5+h|0x0074 | |||
| h|Field |Bits |R/W |Default |Description | |||
| |{set:cellbgcolor:#FFFFFF}svw |15:0 |R |DC | Subsequent violations in the window indexed by *svi*. *svw[_j_]*=1 for the at lease one subsequent violation issued from RRID= *svi**16 + _j_. | |||
| |{set:cellbgcolor:#FFFFFF}svi |27:16 |RW |0 | Window's index to search subsequent violations. When read, *svi* moves forward until one subsequent violation is found or *svi* has been rounded back to the same value. After read, the window's content, *svw*, should be clean. | |||
| |{set:cellbgcolor:#FFFFFF}svi |27:16 |WARL |0 | Window's index to search subsequent violations. When read, *svi* moves forward until one subsequent violation is found or *svi* has been rounded back to the same value. After read, the window's content, *svw*, should be clean. | |||
There was a problem hiding this comment.
When read, svi moves forward until one subsequent violation is found or svi has been rounded back to the same value.
What if the written value is invalid.
For example, IOPMP supports 32 RRIDs.
Obviously, only first bit of ERR_MFR.svi may be necessary and implemented.
If a programmer writes ERR_MFR.svi=0xF and read it back without any subsequent violations, what should the value of ERR_MFR.svi be when reading ?
There was a problem hiding this comment.
This is implementation-dependent.
For example, there are two design choices: (1) implement only two windows (32 RRIDs), and (2) implement all windows and the windows except window 0 and window 1 are read only 0.
ERR_MFR.svi can be 0x0 or 0x1 if the IOPMP is choice (1).
ERR_MFR.svi can be 0xf if the IOPMP is choice (2).
Update behavior of ERR_MFR.svi from RW to WARL.
Update bit width of MDCFGLCK.f is 6:1.
Update bit width of MDCFGLCK.rsv is 31:7.