Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zicsr, Zicboz order is wrong in CMO tests #472

Closed
Timmmm opened this issue Jun 11, 2024 · 1 comment
Closed

Zicsr, Zicboz order is wrong in CMO tests #472

Timmmm opened this issue Jun 11, 2024 · 1 comment

Comments

@Timmmm
Copy link
Contributor

Timmmm commented Jun 11, 2024

See this comment.

The order of the regex matching the extensions was accidentally changed so that it doesn't match the order that riscv-config enforces. That means the CBO tests can never be selected.

I should also note that using regexes here is really bad engineering precisely because things like this are so likely to happen. A better engineered solution would use a set to store the set of extensions (clue's in the name) that the ISA string specifies.

@UmerShahidengr
Copy link
Collaborator

It has been resolved via #473 . Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants