Miscellaneous fixes and tweaks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are outdated and by definition always will be. People might download them believing that they reflect the current contents of the spec, which could lead to confusion. We should just publish artifacts as part of tagged releases, same as is done for other specs. Signed-off-by: Andrea Bolognani <[email protected]>
Requirements that the spec considers mandatory need to be indicated by using the all-caps MUST. Signed-off-by: Andrea Bolognani <[email protected]>
Signed-off-by: Andrea Bolognani <[email protected]>
The closing bracket being missing leads to broken rendering. Signed-off-by: Andrea Bolognani <[email protected]>
The section that talks about PCIe devices might have been 2.5.11 in the past, but 2.4 is the best match as of today. Signed-off-by: Andrea Bolognani <[email protected]>
Signed-off-by: Andrea Bolognani <[email protected]>
These are mandatory parts of the spec, and they should be marked as such by the use of MUST. Signed-off-by: Andrea Bolognani <[email protected]>
Signed-off-by: Andrea Bolognani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing Earth-shattering, just addressing a few minor things that I've noticed while reviewing the current spec.