Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C/C++ preprocessor definitions #57

Open
christian-herber-nxp opened this issue Sep 4, 2024 · 1 comment
Open

C/C++ preprocessor definitions #57

christian-herber-nxp opened this issue Sep 4, 2024 · 1 comment

Comments

@christian-herber-nxp
Copy link

__riscv_mul: defined when targeting the 'M' ISA extension.

I think it is safe to change this to targeting the 'M' or "Zmul' ISA extension.

__riscv_compressed: defined when targeting the 'C' ISA extension.

How is this expected to behave when not the full C, but elements of Zc are implemented?
@cmuellner
Copy link
Collaborator

It is safe from a "functionality included in an extension" view.
That does not mean that it still cannot break builds.

I'm okay with this such a change if LLVM and GCC maintainers accept patches that implement this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmuellner @christian-herber-nxp