-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import preprocessing error #128
Comments
This is caused by #122. For now the workaround is to install a newer version of riscv-isac manually. The instructions in that issue are no longer up to date because riscv-isac has been moved to the riscv-arch-test repo. The following command should work:
|
@UmerShahidengr It seems like there won't be further packaged pip releases of riscv-isac now that it has been directly incorporated into riscv-arch-test. That leaves the default install of riscof unusable in its current state. Is there a reason not to incorporate riscof into the riscv-arch-test repo as well to avoid these issues? |
@jordancarlin @UmerShahidengr |
@itsubaidrehman Unfortunately that installs an older version from January 2023. At a minimum I believe that version is missing features needed for testing the privileged architecture. |
@jordancarlin I tried to install using |
Maybe try uninstalling riscof and riscv-isac first? Maybe also try removing everything from the pip cache? The following two commands work to install riscv-isac and riscof in a functional state for me.
The other option I can think of trying is to replace the current riscv-isac line in the requirements.txt file with |
@jordancarlin I have checkout to d38859f commit and then installed riscof and it worked. Now i did not get import preprocessing error. |
That makes sense. It was commit dddbc52 that introduced the feature that is dependent on the newer version of riscv-isac. Some of those features will be needed for privileged tests, but if it works fine for now without it then I guess maybe that's good enough. |
@jordancarlin but still, if some one has to use those features, what could be the possible solutions to avoid this error? |
The only solutions I'm aware of are the two I listed above. Not sure why neither worked for you. Ideally the longer term solution would be to merge riscof into riscv-arch-test so that they can't get out of sync and don't have weird dependencies. |
@jordancarlin I have installed riscof with these two commands ERROR | Covergroup(s) for ('CHK_M_INTR_PRIORITY',) not found |
I've spent a while working on installation related issues but am not very familiar with actually using riscof for coverage, so I'm not sure that I can be much help at this point. |
Just chiming in, Im running into this issue as well:
|
@zaun hopefully these two commands will install the RISCoF framwork setup without these error. |
@itsubaidrehman Unfortunately no.
|
@itsubaidrehman Can you try installing using pip inside of a single virtual environment instead of pipx to see if it is an issue with the way pipx is handling it?
|
So, yeah that works. I'm not dont know python or pip/pipx well enough to know why it worked and pipx didn't though. Maybe is something with being on macOS or python/pipx being from brew? This is the full log:
If it helps, these are my normal versions:
|
I think pipx installs everything in its own dedicated virtual environment, so when using pipx the newer version of riscv-isac is probably not visible to riscof and it falls back to using the older one that is published to PyPi. There is probably a way around that, but I haven't used pipx so am not familiar with what that would be. |
I am trying to install RISCoF framework but getting preprocessing error.
File "/home/lpt-10xe/riscof/riscof/cli.py", line 18, in
import riscof.framework.main as framework
File "/home/lpt-10xe/riscof/riscof/framework/main.py", line 11, in
from riscv_isac.isac import preprocessing
ImportError: cannot import name 'preprocessing' from 'riscv_isac.isac' (/home/lpt-10xe/.local/lib/python3.10/site-packages/riscv_isac/isac.py)
The text was updated successfully, but these errors were encountered: