Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction description enhancement #187

Closed
AFOliveira opened this issue Oct 25, 2024 · 4 comments
Closed

Instruction description enhancement #187

AFOliveira opened this issue Oct 25, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@AFOliveira
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
On Instructions yaml files: Excluded by field can only take one extensions, but an instruction could be excluded by more that one extension.

Describe the solution you'd like
Set it has the definedBy: field. Let it have anyOf, allOf.

Additional context
Zext.h example:
excludedBy: [Zk, Zkn, Zks, Zbkb]

@AFOliveira AFOliveira added the enhancement New feature or request label Oct 25, 2024
AFOliveira added a commit that referenced this issue Oct 25, 2024
@dhower-qc dhower-qc self-assigned this Oct 25, 2024
@dhower-qc
Copy link
Collaborator

I'll get this fixed so it works just like definedBy

@dhower-qc
Copy link
Collaborator

Actually, I just looked and I think both the schema and Ruby object model for instruction.excludedBy should accept the same as definedBy. Are you up to date with the main branch?

@AFOliveira
Copy link
Collaborator Author

I think it broke my regression test, but it could have been my mistake. I'll try again and get back here.

@AFOliveira
Copy link
Collaborator Author

AFOliveira commented Oct 27, 2024

@dhower-qc It was my mistake. Thank you for the clarification. Already fixed zext.h in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants