Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore name of MockCertificateModel #273

Closed
james-ball-qualcomm opened this issue Nov 16, 2024 · 1 comment · Fixed by #274
Closed

Restore name of MockCertificateModel #273

james-ball-qualcomm opened this issue Nov 16, 2024 · 1 comment · Fixed by #274
Assignees
Labels
bug Something isn't working

Comments

@james-ball-qualcomm
Copy link
Collaborator

Was change by @dhower-qc in #271

@james-ball-qualcomm james-ball-qualcomm added the bug Something isn't working label Nov 16, 2024
@james-ball-qualcomm james-ball-qualcomm self-assigned this Nov 16, 2024
@james-ball-qualcomm
Copy link
Collaborator Author

james-ball-qualcomm commented Nov 16, 2024

I see I had a model key in Certificate Models but it wasn't used anywhere so I removed it. I also updated the schema to remove model and then changed the model name to be any string that can be a hash key (copied from model class schema). The idea is that a certificate class has a particular naming scheme for models in that certificate class so just because MC100 has a naming convention that MC is the class name and 100 is the model number, you can't assume this for all certificate models. In particular, the MockCertificateClass has no naming convention for its certificate models so this provides the necessary coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant