Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing recommendations to Profiles #303

Closed
james-ball-qualcomm opened this issue Nov 22, 2024 · 1 comment · Fixed by #306
Closed

Add missing recommendations to Profiles #303

james-ball-qualcomm opened this issue Nov 22, 2024 · 1 comment · Fixed by #306
Assignees
Labels
enhancement New feature or request

Comments

@james-ball-qualcomm
Copy link
Collaborator

I added support for recommendations (see issue #238) but didn't actually put in the recommendations into the Profile release YAML files. So, we should add those.

Dave you can handle RVA23/RVB23 recommendations. Do you also want to handle RVA20, RVA22, and RVI20 or do you want me to do that? If you see the MockProfileRelease yaml file it has an example of how to add recommendations to a profile (at the end of its yaml file). It is pretty straightforward.

@dlweaver
Copy link
Collaborator

Sure, I'll do that for RVA23 + RVB23.
I'd rather you handle the other ones, as I have a lot of other tasks piling up right now ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants