Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnyOf vs AllOf #362

Open
AFOliveira opened this issue Dec 18, 2024 · 6 comments
Open

AnyOf vs AllOf #362

AFOliveira opened this issue Dec 18, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@AFOliveira
Copy link
Collaborator

Describe the bug
Some instructions have AnyOf and AllOf wrongly assigned. I'm trying to catch them all and submit a PR soon.
@BrianAnakPintar can you please address some examples of that?

@AFOliveira AFOliveira added the bug Something isn't working label Dec 18, 2024
@AFOliveira AFOliveira self-assigned this Dec 18, 2024
@BrianAnakPintar
Copy link
Contributor

Examples:

froundnx.h

UDB

kind: instruction
name: froundnx.h
long_name: No synopsis available.
description: |
  No description available.
definedBy:
  anyOf: [Zfa, Zfh]

riscv-opcodes

"froundnx_h": {
    "encoding": "010001000101-------------1010011",
    "variable_fields": [
        "rd",
        "rm",
        "rs1"
    ],
    "extension": [
        "rv_zfh_zfa"
    ],

froundnx.q

UDB

name: froundnx.h
long_name: No synopsis available.
description: |
  No description available.
definedBy:
  anyOf: [Zfa, Zfh]

riscv-opcodes

"froundnx_q": {
    "encoding": "010001100101-------------1010011",
    "variable_fields": [
        "rd",
        "rm",
        "rs1"
    ],
    "extension": [
        "rv_q_zfa"
    ],
    "match": "0x46500053",
    "mask": "0xfff0007f"
},

fmvp.q.x

UDB

name: fmvp.q.x
long_name: No synopsis available.
description: |
  No description available.
definedBy:
  anyOf: [Q, Zfa]

riscv-opcodes

 "fmvp_q_x": {
    "encoding": "1011011----------000-----1010011",
    "variable_fields": [
        "rd",
        "rs1",
        "rs2"
    ],
    "extension": [
        "rv64_q_zfa"
    ],
    "match": "0xb6000053",
    "mask": "0xfe00707f"
    },

Others include:
fround.q, fmvp.d.x and more.

@AFOliveira
Copy link
Collaborator Author

Thanks!

@AFOliveira
Copy link
Collaborator Author

I was looking to this more thoroughly and I think #350 was supposed to fix this. I also had it fixed on #340 but I though it was already done and closed it. @dhower-qc was it that you maybe missed one commit or was it that our communication was wrong at the time?

@AFOliveira
Copy link
Collaborator Author

I went through the files committed and I believe some were missed by #350, should I reopen #340 , rebase and merge?

@dhower-qc
Copy link
Collaborator

I converted the string "[Za, Zb]" -> the object { anyOf: [Za, Zb] }. I didn't distinguish between cases that should have been allOf instead of anyOf.

@AFOliveira
Copy link
Collaborator Author

Now that I look at it, I misexplained myself at that time, my bad :). I'll reopen it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants