Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing base on some instructions #363

Open
BrianAnakPintar opened this issue Dec 18, 2024 · 1 comment
Open

Missing base on some instructions #363

BrianAnakPintar opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels
data error An error in the database data

Comments

@BrianAnakPintar
Copy link
Contributor

Current value and location
Instructions such as sc_d, remuw, remw, mulw, divuw are missing base:64 for 64

Here's some example to showcase what I meant:

UDB

"sc_d": {
  "encoding": "00011------------011-----0101111",
  "variable_fields": [
      "aq",
      "rd",
      "rl",
      "rs1",
      "rs2"
  ],
  "extension": [
      "rv_a",
      "rv_zalrsc"
  ],
  "match": "0x1800302f",
  "mask": "0xf800707f"
  },

"remuw": {
  "encoding": "0000001----------111-----0111011",
  "variable_fields": [
      "rd",
      "rs1",
      "rs2"
  ],
  "extension": [
      "rv_m"
  ],
  "match": "0x200703b",
  "mask": "0xfe00707f"
  },

riscv-opcodes

"sc_d": {
  "encoding": "00011------------011-----0101111",
  "variable_fields": [
      "aq",
      "rd",
      "rl",
      "rs1",
      "rs2"
  ],
  "extension": [
      "rv64_a"
  ],
  "match": "0x1800302f",
  "mask": "0xf800707f"
  },

"remuw": {
    "encoding": "0000001----------111-----0111011",
    "variable_fields": [
        "rd",
        "rs1",
        "rs2"
    ],
    "extension": [
        "rv64_m"
    ],
    "match": "0x200703b",
    "mask": "0xfe00707f"
},
@BrianAnakPintar BrianAnakPintar added the data error An error in the database data label Dec 18, 2024
@AFOliveira AFOliveira self-assigned this Dec 19, 2024
@AFOliveira
Copy link
Collaborator

If you check #376 that should be solved. Please note that some bases are defined as RV64 and RV32 in the case of the instruction encoding differing from one to the other, i.e. bclri

 encoding:
  RV32:
    match: 0100100----------001-----0010011
    variables:
      - name: shamt
        location: 24-20
      - name: rs1
        location: 19-15
      - name: rd
        location: 11-7
  RV64:
    match: 010010-----------001-----0010011
    variables:
      - name: shamt
        location: 25-20
      - name: rs1
        location: 19-15
      - name: rd
        location: 11-7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data error An error in the database data
Projects
None yet
Development

No branches or pull requests

2 participants