Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend moving definition of indirect CSRs into their own chapter and clarifying they are accessed via M-mode or S-mode CSRs. #420

Open
james-ball-qualcomm opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
reorg Reorganization for Priv ISA manual integration v1.0 resolve for 1.0

Comments

@james-ball-qualcomm
Copy link
Collaborator

'The CLIC registers accessed via the indirect CSR mechanism don't belong to a particular mode (M or S). Instead, they exist outside the scope of any particular mode but are accessed via different indirect CSR addresses for M-mode or S-mode. The only difference is that M-mode access sees all the information in the indirect access CSRs where as S-mode "any interrupt i that is not accessible to S-mode appears as hard-wired zeros in clicintip[i], clicintie[i], clicintattr[i], and clicintctl[i]."

We should move the definition of these indirect access CSRs back into their own chapter and then just have smclic and ssclic chapters talk about how to access them from their respective modes and how S-mode sees a subset of the info (the quoted text in the previous chapter)?

@james-ball-qualcomm
Copy link
Collaborator Author

Do you all want me to make this change to the CLIC doc?

@james-ball-qualcomm james-ball-qualcomm self-assigned this Oct 3, 2024
@christian-herber-nxp
Copy link
Collaborator

I think it is reasonable given the current organization.
However, your suggestion made me realize that clicintattr.mode probably should not have the same behavior.
This is a separate issue and i will open that for discussion.
From my point of view, you can go ahead with this one.

@jb-brelot-nxp jb-brelot-nxp added the v1.0 resolve for 1.0 label Oct 7, 2024
@jb-brelot-nxp jb-brelot-nxp added the reorg Reorganization for Priv ISA manual integration label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reorg Reorganization for Priv ISA manual integration v1.0 resolve for 1.0
Projects
None yet
Development

No branches or pull requests

4 participants