-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHERI encodings and CSRs #214
Conversation
tariqkurd-repo
commented
Dec 19, 2023
- first attempt at CSRs and encodings for CHERI
- note that lr/b etc will be a separate extension eventually
This is my first attempt at reserving some encoding and CSR space for CHERI. LR.B, LR.H, SC.B, SC.H need to be in a separate extension, but for use by CHERI software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this repo to reserve opcode space far in advance of an extension's proposal isn't standard practice, and this is an even more unusual corner case since it's really a new base ISA. Still, I think it's helpful to leave this PR open so people can look at the concrete proposal.
Our intention is to keep CHERI as compatible as possible with other extensions, and so tentatively reserving encoding space and CSR numbers help with that goal. When the TG gets going next year we'll make a more formal proposal. |
@aswaterman this branch builds OK - but the |
LLVM also includes a mechanism for detecting encoding conflicts, but it too failed to identify this. Perhaps for the same reason stated by above. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 3 3
Lines 642 642
=======================================
Hits 596 596
Misses 46 46 ☔ View full report in Codecov by Sentry. |
I've changed this to the intended encoding, which is already in riscv-opcodes (riscv/riscv-opcodes#214). The previous one was a typo and conflicted with c.subw.
See: #237 |