Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Print MTI value upon hart update for machine timer interrupt visibility #620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Print MTI value upon hart update for machine timer interrupt visibility #620

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c5556
fix: Print MTI value upon hart update for machine interrupt visibility
Ali-Faraz-10xe Nov 21, 2024
25748bd
remove problematic else condition
Ali-Faraz-10xe Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions model/riscv_platform.sail
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,14 @@ function clint_dispatch() -> unit = {
then print_platform("clint::tick mtime <- " ^ BitStr(mtime));
mip[MTI] = 0b0;
if mtimecmp <=_u mtime then {
mip[MTI] = 0b1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can delete this line.

if get_config_print_platform()
then print_platform(" clint timer pending at mtime " ^ BitStr(mtime));
mip[MTI] = 0b1
then print_platform(" clint timer pending at mtime " ^ BitStr(mtime) ^ " (mip.MTI <- " ^ BitStr(mip[MTI]) ^ ")");
}
else if mtimecmp >_u mtime then {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just be else no?

mip[MTI] = 0b0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant due to the assignment above. Either change this to an else and delete the assignment above or drop this assignment.

if get_config_print_platform()
then print_platform(" clint timer pending at mtime " ^ BitStr(mtime) ^ " (mip.MTI <- " ^ BitStr(mip[MTI]) ^ ")");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message is wrong

}
}

Expand Down