fix: Add read guard on reschedule_lock for drop_streaming_jobs
#20240
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shanicky Chen <[email protected]>
github-actions
bot
added
type/fix
yezizp2012
approved these changes
Jan 21, 2025
kwannoel
approved these changes
Jan 21, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
) Signed-off-by: Shanicky Chen <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
) Signed-off-by: Shanicky Chen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
) (#20251) Signed-off-by: Shanicky Chen <[email protected]> Co-authored-by: Shanicky Chen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
) (#20250) Signed-off-by: Shanicky Chen <[email protected]> Co-authored-by: Shanicky Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
closing #20168
testing by #20186
In rare circumstances, this can lead to a race condition where the target table in the offline scaling process has already been dropped.
Checklist