From 24569b850a472b5ed2136c051ae3df6789ce2e0e Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Wed, 6 Nov 2024 15:15:53 -0300 Subject: [PATCH] linters: Remove pydocstyle from linter checks Pydocstyle has been deprecated is no longer in development. It is also not a requirement for Ansible tests. This patch removes pydocstyle from current checks performed. --- .github/workflows/lint.yml | 15 --------------- .pre-commit-config.yaml | 4 ---- requirements-dev.txt | 1 - setup.cfg | 4 ---- utils/lint_check.sh | 2 -- 5 files changed, 26 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3eb9305fe8..bfddba605d 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -34,21 +34,6 @@ jobs: - name: Run yaml-lint uses: ibiqlik/action-yamllint@v3.1.1 - pydocstyle: - name: Verify pydocstyle - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4.1.1 - with: - fetch-depth: 1 - - uses: actions/setup-python@v5.1.0 - with: - python-version: "3.x" - - name: Run pydocstyle - run: | - pip install pydocstyle - pydocstyle - flake8: name: Verify flake8 runs-on: ubuntu-latest diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 23fa16cac8..248374ca23 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -29,10 +29,6 @@ repos: rev: 7.0.0 hooks: - id: flake8 -- repo: https://github.com/pycqa/pydocstyle - rev: 6.3.0 - hooks: - - id: pydocstyle - repo: https://github.com/pycqa/pylint rev: v3.2.2 hooks: diff --git a/requirements-dev.txt b/requirements-dev.txt index 08e3366214..5a347cb673 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -5,6 +5,5 @@ flake8==7.0.0 flake8-bugbear pylint>=3.2 wrapt==1.14.1 -pydocstyle==6.3.0 yamllint==1.35.1 ansible-lint>=24.5.0 diff --git a/setup.cfg b/setup.cfg index 4d2eefa61e..c44ac599c7 100644 --- a/setup.cfg +++ b/setup.cfg @@ -28,10 +28,6 @@ per-file-ignores = plugins/*:E402 roles/*:E402 -[pydocstyle] -inherit = false -ignore = D1,D212,D203 - [pylint.MASTER] disable = consider-using-f-string, # f-string is not supported on Python2 diff --git a/utils/lint_check.sh b/utils/lint_check.sh index 76c8c2ace1..34ca8d49b9 100755 --- a/utils/lint_check.sh +++ b/utils/lint_check.sh @@ -10,8 +10,6 @@ pushd "${topdir}/.." >/dev/null 2>&1 || exit 1 echo -e "${INFO}Running 'flake8'...${RST}" flake8 plugins utils roles setup.py -echo -e "${INFO}Running 'pydocstyle'...${RST}" -pydocstyle plugins utils roles setup.py echo -e "${INFO}Running 'pylint'...${RST}" pylint plugins roles setup.py