Skip to content

Commit

Permalink
idoveridegroup: Use module.params_get_type
Browse files Browse the repository at this point in the history
Use the commom parameter type handling method for parameters that accept
a value or an empty string.
  • Loading branch information
rjeffman committed Sep 25, 2023
1 parent ab8080a commit 8f8f976
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
2 changes: 1 addition & 1 deletion plugins/modules/ipaconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def main():
params = {}
for x in field_map:
val = ansible_module.params_get(
x, allow_empty_list_item=(x in allow_empty_list_item))
x, allow_empty_list_item=x in allow_empty_list_item)

if val is not None:
params[field_map.get(x, x)] = val
Expand Down
15 changes: 1 addition & 14 deletions plugins/modules/ipaidoverridegroup.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def main():
# present
description = ansible_module.params_get("description")
name = ansible_module.params_get("name")
gid = ansible_module.params_get("gid")
gid = ansible_module.params_get_type("gid", int)

# runtime flags
fallback_to_ldap = ansible_module.params_get("fallback_to_ldap")
Expand Down Expand Up @@ -271,19 +271,6 @@ def main():

ansible_module.params_fail_used_invalid(invalid, state)

# Ensure parameter values are valid and have proper type.
def int_or_empty_param(value, param):
if value is not None and value != "":
try:
value = int(value)
except ValueError:
ansible_module.fail_json(
msg="Invalid value '%s' for argument '%s'" % (value, param)
)
return value

gid = int_or_empty_param(gid, "gid")

# Init

changed = False
Expand Down

0 comments on commit 8f8f976

Please sign in to comment.