If URI is not a regex pattern then always sanitise #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey thx man, im actually going to be re-writting this when I can finally spare a moment! |
auralon
added a commit
to auralon/Craft-Plugin--Redirect-Manager
that referenced
this pull request
Nov 20, 2017
When running a console command, I stumbled upon this error...
PHP Error[8]: Undefined index: SERVER_NAME
in file /var/www/foobar/craft/app/framework/web/CHttpRequest.php at line 352
#0 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(265): Craft\ConsoleApp->handleError()
rkingon#1 /var/www/foobar/craft/app/framework/web/CHttpRequest.php(352): Craft\ConsoleApp->handleError()
rkingon#2 /var/www/foobar/craft/app/services/ConfigService.php(420): Craft\HttpRequestService->getHostInfo()
rkingon#3 /var/www/foobar/craft/app/etc/web/UrlManager.php(80): Craft\ConfigService->usePathInfo()
rkingon#4 /var/www/foobar/craft/app/framework/base/CModule.php(394): Craft\UrlManager->init()
rkingon#5 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(220): Craft\ConsoleApp->getComponent()
rkingon#6 /var/www/foobar/craft/app/framework/base/CModule.php(103): Craft\ConsoleApp->getComponent()
rkingon#7 /var/www/foobar/craft/app/services/HttpRequestService.php(1163): Craft\ConsoleApp->__get()
rkingon#8 /var/www/foobar/craft/plugins/redirectmanager/RedirectManagerPlugin.php(43): Craft\HttpRequestService->getQueryStringWithoutPath()
rkingon#9 /var/www/foobar/craft/app/services/PluginsService.php(150): Craft\RedirectManagerPlugin->init()
rkingon#10 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(86): Craft\PluginsService->loadPlugins()
rkingon#11 /var/www/foobar/craft/app/framework/base/CApplication.php(170): Craft\ConsoleApp->init()
rkingon#12 /var/www/foobar/craft/app/framework/YiiBase.php(121): Craft\ConsoleApp->__construct()
rkingon#13 /var/www/foobar/craft/app/etc/console/yiic.php(86): createApplication()
rkingon#14 /var/www/foobar/utils/yiic_frontend.php(24): require()
This patch fixes the issue.
rkingon
pushed a commit
that referenced
this pull request
Nov 20, 2017
When running a console command, I stumbled upon this error...
PHP Error[8]: Undefined index: SERVER_NAME
in file /var/www/foobar/craft/app/framework/web/CHttpRequest.php at line 352
#0 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(265): Craft\ConsoleApp->handleError()
#1 /var/www/foobar/craft/app/framework/web/CHttpRequest.php(352): Craft\ConsoleApp->handleError()
#2 /var/www/foobar/craft/app/services/ConfigService.php(420): Craft\HttpRequestService->getHostInfo()
#3 /var/www/foobar/craft/app/etc/web/UrlManager.php(80): Craft\ConfigService->usePathInfo()
#4 /var/www/foobar/craft/app/framework/base/CModule.php(394): Craft\UrlManager->init()
#5 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(220): Craft\ConsoleApp->getComponent()
#6 /var/www/foobar/craft/app/framework/base/CModule.php(103): Craft\ConsoleApp->getComponent()
#7 /var/www/foobar/craft/app/services/HttpRequestService.php(1163): Craft\ConsoleApp->__get()
#8 /var/www/foobar/craft/plugins/redirectmanager/RedirectManagerPlugin.php(43): Craft\HttpRequestService->getQueryStringWithoutPath()
#9 /var/www/foobar/craft/app/services/PluginsService.php(150): Craft\RedirectManagerPlugin->init()
#10 /var/www/foobar/craft/app/etc/console/ConsoleApp.php(86): Craft\PluginsService->loadPlugins()
#11 /var/www/foobar/craft/app/framework/base/CApplication.php(170): Craft\ConsoleApp->init()
#12 /var/www/foobar/craft/app/framework/YiiBase.php(121): Craft\ConsoleApp->__construct()
#13 /var/www/foobar/craft/app/etc/console/yiic.php(86): createApplication()
#14 /var/www/foobar/utils/yiic_frontend.php(24): require()
This patch fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of the CMS crashing in Dev mode if the URI is not a regular expression pattern.
Relates to #5.