Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Cmd Escape Path issues with new terminal profiles #35

Open
Inch4Tk opened this issue Oct 1, 2021 · 5 comments
Open

Windows Cmd Escape Path issues with new terminal profiles #35

Inch4Tk opened this issue Oct 1, 2021 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@Inch4Tk
Copy link
Contributor

Inch4Tk commented Oct 1, 2021

Same error as in issue #23, now caused by using terminal profiles instead of the deprecated terminal.integrated.shell config.
The fix is straightforward, if the old term shell value is not set just query for the new default profile and check for cmd.exe there.

I will add a pull request.

@rlivings39
Copy link
Owner

Closing based on merged PR. Please reopen if this is still an issue.

@madjestic
Copy link

madjestic commented Sep 1, 2022

Hey guys, I am experiencing the same issue on Windows 10.

Editing extension.js and making escapeWinPath return origPath seems to be fixing the issue.
(as mentioned in #23 )

@rlivings39
Copy link
Owner

rlivings39 commented Nov 9, 2023

Hey guys, I am experiencing the same issue on Windows 10.
Editing extension.js and making escapeWinPath return origPath seems to be fixing the issue. (as mentioned in #23 )

Please provide more details please. Where is the file extension.js file ? I can not find it though.

It's in the folder where extensions are installed:

https://code.visualstudio.com/docs/editor/extension-marketplace

On Windows, have a look in %USERPROFILE%\.vscode\extensions\rlivings39.fzf-quick-open-0.5.1\out\extension.js

Would you mind sharing the terminal settings from your settings.json? I'm guessing something is still messed up with that.

@rlivings39 rlivings39 reopened this Nov 9, 2023
@rlivings39 rlivings39 added the help wanted Extra attention is needed label Nov 9, 2023
@rlivings39
Copy link
Owner

Marking this as help wanted since I don't have access to any Windows machines right now. Any Windows-based contributor would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants
@Inch4Tk @madjestic @rlivings39 and others