Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoDaddy plugin doesn't work with Domain Protection enabled #594

Open
BearGFR opened this issue Jan 23, 2025 · 2 comments
Open

GoDaddy plugin doesn't work with Domain Protection enabled #594

BearGFR opened this issue Jan 23, 2025 · 2 comments
Assignees
Labels
cantfix Unable to fix due to upstream limitations

Comments

@BearGFR
Copy link

BearGFR commented Jan 23, 2025

To be clear, this is not an issue with your code or the godaddy plugin, but an issue with godaddy itself. I'm merely raising this as an issue for awareness.

The issue is, when working with a domain registered through godaddy (or using godaddy for DNS), if that domain has godaddy's "Domain Proctection" feature enabled, then their API for creating DNS records -does not work-. What happens, at least in the case of TXT records, is that the record will be created but the body/text portion of the record will be completely empty. Of course this causes the new-PAcertificate function to fail because the output TXT record in the godaddy DNS will not contain the needed validation key.

I proved this myself just moments ago. Yesterday I added domain protection to just one of my domains, then later discovered that new-PAcertificate was failing due to a blank _acme-challenge record. The very same code worked fine against another godaddy domain of mine that does not have protection enabled. I finally made the connection, and disabled protection on the one domain that had been failing, and now it works fine.

@rmbolger rmbolger self-assigned this Jan 23, 2025
@rmbolger rmbolger added the cantfix Unable to fix due to upstream limitations label Jan 23, 2025
@rmbolger rmbolger changed the title Issue with GoDaddy itself when using the godaddy plugin GoDaddy plugin doesn't work with Domain Protection enabled Jan 23, 2025
@rmbolger
Copy link
Owner

Hey @BearGFR, thanks for the heads up! I'll add a warning to the plugin guide.

@BearGFR
Copy link
Author

BearGFR commented Jan 23, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cantfix Unable to fix due to upstream limitations
Projects
None yet
Development

No branches or pull requests

2 participants