Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "open_in = iframe" for middle mouse button clicks and open in new tab without embedding #171

Open
ThelloD opened this issue May 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ThelloD
Copy link

ThelloD commented May 28, 2020

Embedding apps in DashMachine is great, but sometimes I would like to be able to quickly open certain apps (well, URLs) in a new tab without the application being embedded in DashMachine in an iframe. This is e.g. especially useful if some special functions of the embedded web application behave buggy if they are embedded.

One possible solution might be be to have the href= attribute always pointing to the real URL and handling left button clicks using JavaScript onClick events, which then redirects the user to the URL with the iframe (=the URL currently in the href tag). Since the onclick event is ignored for middle mouse button clicks, such clicks would then open the application in a new tab which points directly to the web application URL.

@rmountjoy92
Copy link
Owner

I agree, I mostly don't use the iframe option because of this lol. This could be solved by the upcoming feature I'm planning: ability to add custom buttons on apps. That way you could make 'open in new tab' button on iframe apps that need it.

@rmountjoy92 rmountjoy92 added the enhancement New feature or request label May 30, 2020
@saponace
Copy link

saponace commented Jun 3, 2020

I agree, I mostly don't use the iframe option because of this lol. This could be solved by the upcoming feature I'm planning: ability to add custom buttons on apps. That way you could make 'open in new tab' button on iframe apps that need it.

This could be an option, but I believe, having only the app icon to click on would be simpler:

  • left click: open in iframe
  • middle click: open in new tab (usual behavior on the web)

Coming From Organizr where I had all my apps in iframe mode (I would often middle click to open them in new tabs), I found myself having to set all apps to "new_tab" instead of iframe, because even if you usually use apps in iframe, the day you want to open you app in a new tab, you are kind of stuck ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants