Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Royalty should be set in basis points #32

Open
ilionic opened this issue Jan 8, 2023 · 1 comment
Open

Royalty should be set in basis points #32

ilionic opened this issue Jan 8, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ilionic
Copy link
Contributor

ilionic commented Jan 8, 2023

Update royalty from u8 to u16 to represent basis points ( so client side could interpret two decimal fractional royalties ie 12.25% )

@Maar-io
Copy link
Contributor

Maar-io commented Mar 17, 2023

Royalties are still not implemented. This could be good first PR

@Maar-io Maar-io added the good first issue Good for newcomers label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants