Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-convergence still needs to call budget routines #1

Open
emorway-usgs opened this issue Oct 23, 2017 · 0 comments
Open

non-convergence still needs to call budget routines #1

emorway-usgs opened this issue Oct 23, 2017 · 0 comments

Comments

@emorway-usgs
Copy link
Collaborator

In the Sagehen example, with it running all the way through as of 10/23/17, there were roughly a half-dozen time steps that didn't converge but the budget routines are not being called. To fix this, the order of these two if statements should be switched in the custom code:

if (!MS_GSF_converge)
{
    afr = false;
    MFRunYet = true;
    //MODFLOWConverge = CheckOscillating(MF_Segs);
} else
{
    gsflow_prms(ref Process_mode, ref afr, ref MS_GSF_converge, ref Nsegshold, ref Nlakeshold, MS_Flows, IDivert, EXCHANGE, 
                DELTAVOL, LAKEVOL);
    afr = true;   
}

if (myModel.mInfo.Iteration > myModel.maxit)
{
    Console.WriteLine("Ran into maximum number of iterations - Warning !!! models have not converged.");
    MS_GSF_converge = true;
}

However, this resulted in many more time steps not converging. I undid the change for now, but we still need to get to the bottom of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant