Change compassViewPosition to type string, instead of number... #1569
thispastwinter
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
Thanks for appropriately categorizing this! Shouldn't have filed this in issues. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently compassViewPosition accepts a number range from 0-4. I don't feel this is very intuitive. I think it makes more sense to just have 4 string types.
Example:
type CompassViewPosition = "topLeft" | "topRight" | "bottomLeft" | "bottomRight"
What this would then look like:
Apologies for not necessarily following the template to a "t", as this isn't really a bug, but a preference over the current api. I'm also happy to put up a PR if anyone else agrees with this.
Beta Was this translation helpful? Give feedback.
All reactions