onMapLoadingError for Android **on v11** ?

[enlivn]

Hello, I see that onMapLoadingError not working on Android was fixed last year and shipped with release 10.0.9.

We're using the v11 version on the native side by specifying in our build.gradle

RNMapboxMapsVersion = '11.6.0'

which provides a new API to listen to errors

This means we'd in theory have to use that API on the RN side instead of:

maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt

Lines 382 to 390 in fa80ae5

	map.subscribe({ event ->
	Logger.e(LOG_TAG, String.format("Map load failed: %s", event.data.toString()))
	val errorMessage = event.getMapLoadingErrorEventData().message
	val event = MapChangeEvent(this, EventTypes.MAP_LOADING_ERROR, writableMapOf(
	"error" to errorMessage
	))
	mManager.handleEvent(event)
	}, Arrays.asList(MapEvents.MAP_LOADING_ERROR))

Are there any plans to implement this ? Are there any other workarounds ?

[enlivn]

Here's a simple workaround for this issue:

Update your app/build.gradle file to switch from the v10 to the v11 API at build time.

edit: updated to fix some indentation in the text to replace

tasks.register('fixMapLoadingErrorForMapboxV11') {
    doLast {
        // With Mapbox native v11, there is a new API to detect map loading errors. The old v10 API is NOP'ed.
        // The main RN library has not been updated to use this new API and instead uses the old v10 API. This
        // gradle task switches to the new API at build time.
        def libFile = new File(rootProject.projectDir, '../node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt')

        if (libFile.exists()) {
            def v10MapLoadingErrorApi = '''map.subscribe({ event ->
            Logger.e(LOG_TAG, String.format("Map load failed: %s", event.data.toString()))
            val errorMessage = event.getMapLoadingErrorEventData().message
            val event = MapChangeEvent(this, EventTypes.MAP_LOADING_ERROR, writableMapOf(
                    "error" to errorMessage
            ))
            mManager.handleEvent(event)

                      }, Arrays.asList(MapEvents.MAP_LOADING_ERROR))'''

            def v11MapLoadingErrorApi = '''map.subscribeMapLoadingError { error ->
            val event = MapChangeEvent(
                this, EventTypes.MAP_LOADING_ERROR, writableMapOf(
                    "error" to error.message
                )
            )
            mManager.handleEvent(event)
        }
            '''

            libFile.text = libFile.text.replace(v10MapLoadingErrorApi, v11MapLoadingErrorApi)
        }
    }
}

tasks.named('preBuild') {
    dependsOn('fixMapLoadingErrorForMapboxV11')
}