-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: (Android only) onMapIdle (etc) does not trigger with a native UserLocation #2902
Comments
I also got this issue |
What is the use case for onMapIdle? It seems that the pulsing is useLocation prevents the map renderer from going to idle, so onMapIdle will not be called. |
Effectively, we wanted to use it as a replacement for onRegionDidChange. One use case is to capture and store the latest viewport that the user panned to. It looks like onMapIdle has a more render-focused meaning. However, I'm not sure how to achieve this right now with v10. Maybe the wrapper needs some camera lifecycle callbacks? |
@savv thanks much, they suggest adding camera animation observers for that purpose. I'll try to implement that and we'll see if that meets your use case. You're right that onMapIdle is not a replacement for onRegionDidChange |
We have the same issue, |
For now the workaround is to use debounce onCameraChanged. That should be called when map stopped changing for a while |
Do you think we should change the function jsdoc in the MapView.tsx file related to
And also in the console warning. maps/src/components/MapView.tsx Lines 540 to 542 in 27ab126
If you think its a good idea I can pop in a PR for it. |
Valid bug, but not planned do to lack of resources. Closing as not planned. I don't think this is to be fixed, but would be nice to provide some solution for the use case. |
Given that this is a bug and not a feature request, it would make sense to me to keep it open. That way, people facing the same issue can find it more easily; and maybe even fix it (or at least update the docs, as somebody already suggested). |
I'm also experiencing this on iOS. Neither |
Mapbox Implementation
Mapbox
Mapbox Version
10.7.0
Platform
Android
@rnmapbox/maps
version10.0.7
Standalone component to reproduce
In the MapHandlers example, add the following line inside of the MapView:
Observed behavior and steps to reproduce
Observe that onMapIdle does not get called anymore.
Expected behavior
Should still get called.
Notes / preliminary analysis
No response
Additional links and references
No response
The text was updated successfully, but these errors were encountered: