-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo installation instructions fail with error: "Setting $RNMapboxMapsImpl is now required" #3234
Comments
No code example found in issue body - More info |
Not sure what code I am supposed in include here. The issue is with the installation procedure. |
Pls add info so the issue can be reproduced. What is your expo version? What is the rnmapbox version what is your plugin config. |
Running But now I am getting Now to fix that issue I removed |
adding this in ios > Podfile fixed the problem for me
|
So the issue is that #main documents the instructions with 10.1 which is only This was fixed in the install instructions at: And we're now just referring to it. |
@mfazekas I just created a new clean expo project and followed the instructions you linked. However, I'm now running into a different error:
|
@wvteijlingen what is you config file? Do you have also added |
I didn't add the ellipsis. Basically what I did is create a fresh Expo project using // babel.config.js
module.exports = function (api) {
api.cache(true);
return {
presets: ['babel-preset-expo'],
plugins: [
[
"@rnmapbox/maps",
{
"RNMapboxMapsDownloadToken": "<redacted>"
}
]
]
};
}; // package.json
{
"main": "node_modules/expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo run:android",
"ios": "expo run:ios",
"web": "expo start --web"
},
"dependencies": {
"@rnmapbox/maps": "^10.1.3",
"expo": "~49.0.15",
"expo-status-bar": "~1.6.0",
"react": "18.2.0",
"react-native": "0.72.6",
"expo-splash-screen": "~0.20.5"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@types/react": "~18.2.14",
"typescript": "^5.1.3"
},
"private": true
} // App.tsx
import { StatusBar } from 'expo-status-bar';
import { StyleSheet, Text, View } from 'react-native';
import { MapView } from "@rnmapbox/maps";
export default function App() {
return (
<View style={styles.container}>
<Text>Open up App.tsx to start working on your app!</Text>
<StatusBar style="auto" />
</View>
);
} |
Not exactly - the install instructions doesn't mention adding adding anything your |
Aah you're right, I misread that, my mistake! I fixed it, but another issue pops up though:
|
See https://rnmapbox.github.io/docs/install?rebuild=expo#rebuild |
Environment
Steps to reproduce
npx expo run:ios
The error message is quite cryptic, and the provided URL (https://github.com/rnmapbox/maps/wiki/Deprecated-RNMapboxImpl-Unset#ios) isn't very clear on how to fix this either. It just refers the the iOS installation instructions for a bare iOS workflow.
Result
The text was updated successfully, but these errors were encountered: