-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kotlin 1.9.0: npm package build fails #3267
Comments
It's interesting as according to https://github.com/facebook/react-native/blame/746ad378c7efe3ee2f4926ab30e5401407f8b3ba/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java#L242 superclass of AbstractEventEmitter - ViewManager in react-native had the
Unchanged for for years. |
Yes, this is strange. |
My 2 tips, is either your react-native version. - check content of ViewManager.java. Or your kotlin settings in your Gradle files? |
I'm closing this as this sound project specific then. |
I ran into the exact same issue on my project. Environment:
Downgrading Kotlin version to 1.8.0 helped resolve this:
Hope this helps :) |
I got this working after upgraded react-native to version 0.73.1 |
Proposed a PR fix that worked for me, should be an easy patch if anyone else needs to implement it ASAP. Got the inspiration from invertase/react-native-google-mobile-ads#511 |
Any progress there? The fix is easy to apply, but would be good to have working lib release without applying additional patch. |
Like I mentioned earlier, the problem disappeared with the latest React native version. Did not need any patch. |
@mfazekas I just encountered a similar issue, Android build fails after mapbox upgrade. "react-native": "0.72.14",
|
@andreirat That is a bit different issue. See https://github.com/rnmapbox/maps/pull/3465/files You might be able to work around that using
Add this to your andorid/build.gradle file after |
@mfazekas already did that, but it would break other packages we are using. It worked with RN version 0.72.4. |
@andreirat why did it break other packages? Which ones? |
|
@mfazekas downgraded to |
I had the same issue that @andreirat, Environment:
and downgraded to @rnmapbox/maps: 10.1.17, and it works |
Environment
Steps to reproduce
Error:
e: file:///Users/xxx/work/mobile/mobile_app/node_modules/@rnmapbox/maps/android/src/main/java/com/rnmapbox/rnmbx/components/AbstractEventEmitter.kt:53:5 'addEventEmitters' overrides nothing
The text was updated successfully, but these errors were encountered: