Ignore rarely-hit ElGamal code chunk in coverage report.

rnpgp · Mar 18, 2024 · ed0c871 · ed0c871
1 parent 6a8c9a5
commit ed0c871
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/lib/crypto/elgamal.cpp b/src/lib/crypto/elgamal.cpp
@@ -276,8 +276,11 @@ elgamal_generate(rnp::RNG *rng, pgp_eg_key_t *key, size_t keybits)
         goto end;
     }
     if (bn_num_bytes(*y) < BITS_TO_BYTES(keybits)) {
+        /* This code chunk is rarely hit, so ignoring it for the coverage report:
+         * LCOV_EXCL_START */
         botan_privkey_destroy(key_priv);
         goto start;
+        /* LCOV_EXCL_END */
     }
 
     if (botan_privkey_get_field(BN_HANDLE_PTR(p), key_priv, "p") ||

diff --git a/src/lib/crypto/elgamal_ossl.cpp b/src/lib/crypto/elgamal_ossl.cpp
@@ -394,11 +394,14 @@ elgamal_generate(rnp::RNG *rng, pgp_eg_key_t *key, size_t keybits)
             goto done;
         }
         if (y.bytes() != BITS_TO_BYTES(keybits)) {
+            /* This code chunk is rarely hit, so ignoring it for the coverage report:
+             * LCOV_EXCL_START */
             EVP_PKEY_CTX_free(ctx);
             ctx = NULL;
             EVP_PKEY_free(pkey);
             pkey = NULL;
             goto start;
+            /* LCOV_EXCL_END */
         }
 
         rnp::bn p;
@@ -418,11 +421,14 @@ elgamal_generate(rnp::RNG *rng, pgp_eg_key_t *key, size_t keybits)
         goto done;
     }
     if (BITS_TO_BYTES(BN_num_bits(DH_get0_pub_key(dh))) != BITS_TO_BYTES(keybits)) {
+        /* This code chunk is rarely hit, so ignoring it for the coverage report:
+         * LCOV_EXCL_START */
         EVP_PKEY_CTX_free(ctx);
         ctx = NULL;
         EVP_PKEY_free(pkey);
         pkey = NULL;
         goto start;
+        /* LCOV_EXCL_END */
     }
 
     const bignum_t *p;