Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and set the features of keys #2178

Closed
kaie opened this issue Jan 15, 2024 · 2 comments
Closed

Query and set the features of keys #2178

kaie opened this issue Jan 15, 2024 · 2 comments
Milestone

Comments

@kaie
Copy link
Contributor

kaie commented Jan 15, 2024

From RFC 4880 section 5.2.3.3 regarding features on self-signatures:

"It is good practice to verify that a self-signature imported into an implementation doesn't advertise features that the implementation doesn't support, rewriting the signature as appropriate."

As of today, it seems RNP doesn't offer support for checking the advertised features of a key, and also doesn't support changing them.

Because as of today Thunderbird doesn't support v5 keys, we face the issue that keys created with GnuPG 2.4.x advertise support for v5 keys (plus another feature) by default. If a user imports such a key into Thunderbird, and Thunderbird distributes that key, the advertised feature doesn't match the preference of the user's application.

Because GnuPG 2.4 is already widely deployed, I think it is a high priority to allow Thunderbird to fix those keys.

@kaie
Copy link
Contributor Author

kaie commented Jan 15, 2024

I have implemented a patch for RNP, and will submit a PR shortly.

@ni4
Copy link
Contributor

ni4 commented Mar 28, 2024

Fixed via #2179.

@ni4 ni4 closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants