fix issue #2247; use newer kyber _R3 symbols for Botan 3.2.0 upwards #2249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
==========================================
- Coverage 84.02% 84.01% -0.01%
==========================================
Files 114 114
Lines 23062 23062
==========================================
- Hits 19377 19375 -2
- Misses 3685 3687 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TJ-91
force-pushed
the
fix-deprecated-kyber-warnings
branch
from
b73d4a8 to
010e57d
Compare
TJ-91
force-pushed
the
fix-deprecated-kyber-warnings
branch
from
010e57d to
cea8492
Compare
| @@ -32,7 +32,7 @@ find_package(ZLIB REQUIRED) | |||
| # required packages | |||
| find_package(JSON-C 0.11 REQUIRED) | |||
| if (CRYPTO_BACKEND_BOTAN3) | |||
| find_package(Botan 3.0.0 REQUIRED) | |||
| find_package(Botan 3.2.0 REQUIRED) | |||
TJ-91
force-pushed
the
fix-deprecated-kyber-warnings
branch
from
cea8492 to
91dae4c
Compare
TJ-91
force-pushed
the
fix-deprecated-kyber-warnings
branch
from
91dae4c to
865e216
Compare
|
@ni4 here codecov complains but I did not change the code at all aside from renaming an identifier. (And I'm not sure about the windows-msys2 test) |
|
@ni4 Can / should I change anything here? |
TJ-91
force-pushed
the
fix-deprecated-kyber-warnings
branch
from
865e216 to
945700e
Compare
|
Aside from codecov, rebasing worked. Since the final standard version of the PQC algorithms will (most likely) be in Botan 3.6 I propose to just close this PR and get it right with the next big PR. It will change the symbols and required Botan version for PQC again and obsolete this PR. It might take a few weeks. |
fixes #2247 @ni4