Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing destructor for rnp_op_verify_signature_t ? #2257

Closed
csoler opened this issue Aug 2, 2024 · 1 comment · Fixed by #2258
Closed

Missing destructor for rnp_op_verify_signature_t ? #2257

csoler opened this issue Aug 2, 2024 · 1 comment · Fixed by #2258

Comments

@csoler
Copy link

csoler commented Aug 2, 2024

Description

Most functions in RNP return opaque structures that need to be destroyed by the user using a *_destroy function.
It seems however that rnp_op_verify_signature_t doesn't have a corresponding destructor (although it is a pointer).

Is that on purpose?

@ni4
Copy link
Contributor

ni4 commented Aug 2, 2024

Thanks for noticing this! Yes, this is on purpose as handle would point to some internal structure (from the code: *sig = &op->signatures_[idx]; ).
Made PR to update the documentation as well: #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants