-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile issue with rnp and retroshare on macos #2307
Comments
@defnax this is because Botan headers are not found. Most likely because the include path should have |
Thank you for the tip, i has changed i get same errors
i has tested with the direct path, get same errors |
Just re-checked: RNP uses |
i doesnt found yet a solution
|
@defnax Hm, maybe the problem is with extra defines: locally I build it with botan-2 via the single define |
However, for me it works even with these variables. Could you provide CMake command which is executed for rnp build?
|
thx, i will look later, need test it |
i has tested get same error with bigint here is the librnp compile section its in ouer libretroshare.pro project file
i has added for macos compile the mac params, its not yet on master |
@defnax could you please provide the cmake invocation for rnp, i.e. with which exact parameters it was called, not just the output? |
i dont know yet need ask other devs too if they put somewhere cmake defines what i found is this too:
|
i think i posted full cmake function but i see this here maybe this is what you mean?
i has tested with this get exact same bigint issue
|
@defnax I mean the full command with expanded variable values. Looking at https://github.com/RetroShare/libretroshare/blob/650ee8a77ee2f01bc12e234ef194cdbde012a2e8/src/libretroshare.pro#L1163 it seems that RNP path variables are set only for Windows build, or am I wrong? |
There is nothing for macos set, i created myself the cmake params only Im not sure if i need set something? |
What if you just run the following command from the
|
i need to test it tonight |
thank you it seems it helps little bit i get this now
maybe the include path is broken now? when i changed it |
@defnax |
@thunder2 no the file rnp_export.h is not created, that folder is empty |
|
i has copied manually that file "supportlibs\librnp\src\lib\rnp" to the build dir "supportlibs\librnp\Build\src\lib\rnp\rnp_export.h" |
@defnax
At the end you should see
@ni4 Windows native build, Windows msys2 build and Linux build is fine |
|
Ah, okay, mislooked - |
why iget now this "rnp" stop error? |
I doubt that you should call |
i now using copied the manually "supportlibs\librnp\Build\src\lib\rnp\rnp_export.h"
|
You changed the copy directory where cmake is called?
It should be
because the install path is set to -DCMAKE_INSTALL_PREFIX=.
Therefore the file |
i copied manually the when i set back :
get stuck here with big int and configuration stopped
i dont what i need to change to not get stuck at big int issue |
|
yes its there
i use this
but when i use |
after delete seems it worked:
|
but when i did make get this error
|
@defnax Glad that it worked, CMake cache is a misterious thing so it should be definitely cleaned sometimes. P.S. That's strange again, as up-to-date version of |
@defnax In our builds we do not specify include path for c++ headers as CMake is able to detect those automatically. In my case it uses the following command to build: /usr/local/opt/llvm@14/bin/clang++ -DSOURCE_PATH_SIZE=27 -D_GNU_SOURCE -I/Users/user/rnp/src -I/Users/user/rnp/src/lib -I/Users/user/rnp-build/src/lib -I/Users/user/rnp/src/common -I/Users/user/rnp/include -isystem /usr/local/Cellar/json-c/0.17/include/json-c -isystem /usr/local/Cellar/json-c/0.17/include -g3 -O0 -Wsign-compare -Wno-error=sign-compare -fmacro-backtrace-limit=0 -g -std=c++11 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -Wall -Wextra -Wunreachable-code -Wpointer-arith -Wmissing-declarations -Wno-pedantic -Wno-ignored-qualifiers -Wno-unused-parameter -Wno-missing-field-initializers -o CMakeFiles/rnp.dir/__/lib/logging.cpp.o -c /Users/user/rnp/src/lib/logging.cpp I.e. this should define path to the headers: |
...and actual |
im not sure why my cmake does not find the c++ headers, here on my xcode sdk 11.1 there is the include here: its not here or they moved in newer version |
@defnax As far as I remember at some macOS version they moved headers from your location to one I have, so this should not be an issue. Could you check |
hi here:
|
Is this something you expected (and containing all the required headers) : |
No i tried last time into cmake it said not allowed to me with -isysroot i need try tonight again |
@defnax btw, in you CMake configuration logs compiler and ZLib/BZip2 paths are also picked from So possibly you have SDKROOT env variable pointing at it or configured in some other way to use by default SDK from More on this: https://stackoverflow.com/questions/79285785/cmake-for-macos-how-do-i-set-the-isysroot-variable-according-to-my-default-xcod |
yes i saw it now im not sure why it not taked the defined ones
when compiling in retroshare it uses right one
|
i added this to the CMakelists file
|
So does it work now? |
No get error with assert always it does not find the c++ include headers |
i use this cmake include from my other path it dont work
seems i have this same issue like this(https://stackoverflow.com/questions/61741888/i-cannot-compile-a-c-library-using-cmath-on-macos-10-15-4-with-premake5-gmake) |
@defnax Yeah, it looks like you should update XCode. I barely remember something similar few years ago which forced me to update macOS to be able to download and install latest command line tools, as in |
Hi im not able to downloaded latest, i think i need skip till i bought a new mac |
@defnax you may try (if have some time and intention) to build CI/CD pipeline on Github, which would build it/run it/test it/upload compiled artifact, but that could definitely be time-consuming without ability to build the thing on the real mac. I can help with that as well. |
i never used this, you mean with github actions? how i can configure to build for macos as example? some years ago we used travis where it was free for macos builds |
@defnax for opensource projects you may use Github actions for free for (Linux, Windows, macOS) CI/CD builds. That would require some learning if you are not familiar with it right now though. As an example you may check out our actions (folder |
@defnax I don't think that 10.15 is going to work, it's quite outdated. Also Botan 2 is EOLed, so you should try version 3. |
@defnax Oh, macOS could be run in virtualbox. Didn't know till now, in 2010-14 times it was not possible. |
i installed virtualbox two years ago to use macos catalina for build retroshare and make build packages now need to try if rnp builds from qt creator too with rs itself |
This issue seems to be some regression in XCode, there are multiple cases with other products: https://stackoverflow.com/questions/68095018/dyld-symbol-not-found-darwin-check-fd-set-overflow |
this here used in libretroshare the cmake params
without this i get more errors
|
Hello, im not able compile libretroshare with rnp on macos, i get a issue with Botan 2
i installed with brew, json-c and botan@2 and the needed depencies
here is the definition for macos platform to find the libs/include:
The text was updated successfully, but these errors were encountered: