Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of warnings, issued by GCC. #2196

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Mar 6, 2024

Fixes #2156

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (9fd1893) to head (368595d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2196   +/-   ##
=======================================
  Coverage   77.26%   77.27%           
=======================================
  Files         194      194           
  Lines       37751    37770   +19     
=======================================
+ Hits        29170    29186   +16     
- Misses       8581     8584    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 marked this pull request as ready for review March 13, 2024 11:19
@ni4 ni4 force-pushed the ni4-fix-gcc-12-warnings branch from a73e26b to a619d57 Compare March 13, 2024 13:24
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldtse ronaldtse merged commit ed0c871 into main Mar 18, 2024
124 checks passed
@ronaldtse ronaldtse deleted the ni4-fix-gcc-12-warnings branch March 18, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage issue: ElGamal rarely-hit code path missed in #2151
3 participants