Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2247; use newer kyber _R3 symbols for Botan 3.2.0 upwards #2249

Closed
wants to merge 1 commit into from

Conversation

TJ-91
Copy link
Contributor

@TJ-91 TJ-91 commented Jul 9, 2024

fixes #2247 @ni4

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (7724682) to head (945700e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2249      +/-   ##
==========================================
- Coverage   84.02%   84.01%   -0.01%     
==========================================
  Files         114      114              
  Lines       23062    23062              
==========================================
- Hits        19377    19375       -2     
- Misses       3685     3687       +2     
Flag Coverage Δ
84.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TJ-91 TJ-91 force-pushed the fix-deprecated-kyber-warnings branch from b73d4a8 to 010e57d Compare July 10, 2024 08:32
@TJ-91 TJ-91 force-pushed the fix-deprecated-kyber-warnings branch from 010e57d to cea8492 Compare July 30, 2024 05:28
@@ -32,7 +32,7 @@ find_package(ZLIB REQUIRED)
# required packages
find_package(JSON-C 0.11 REQUIRED)
if (CRYPTO_BACKEND_BOTAN3)
find_package(Botan 3.0.0 REQUIRED)
find_package(Botan 3.2.0 REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TJ-91 This should be done only if PQC is enabled, for non-PQC builds we need to support Botan 3.0.0 and 3.1.1 as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ni4 ah, I see. I hope it's good now

@TJ-91 TJ-91 force-pushed the fix-deprecated-kyber-warnings branch from cea8492 to 91dae4c Compare July 30, 2024 14:23
@TJ-91 TJ-91 force-pushed the fix-deprecated-kyber-warnings branch from 91dae4c to 865e216 Compare September 23, 2024 09:06
@TJ-91
Copy link
Contributor Author

TJ-91 commented Sep 23, 2024

@ni4 here codecov complains but I did not change the code at all aside from renaming an identifier. (And I'm not sure about the windows-msys2 test)

@ni4
Copy link
Contributor

ni4 commented Sep 23, 2024

@TJ-91 codecov issue is the following one: #2229
However, msys2 is something new which I didn't see before so filed #2274

@TJ-91
Copy link
Contributor Author

TJ-91 commented Sep 26, 2024

@ni4 Can / should I change anything here?

@ni4
Copy link
Contributor

ni4 commented Sep 26, 2024

@ni4 Can / should I change anything here?

@TJ-91 Probably just force-push with some minor changes to restart the CI in hope of all become green and get merged. Not sure whether issues which cause failure would be resolved quickly.

@TJ-91 TJ-91 force-pushed the fix-deprecated-kyber-warnings branch from 865e216 to 945700e Compare September 27, 2024 08:46
@TJ-91
Copy link
Contributor Author

TJ-91 commented Oct 1, 2024

Aside from codecov, rebasing worked.

Since the final standard version of the PQC algorithms will (most likely) be in Botan 3.6 I propose to just close this PR and get it right with the next big PR. It will change the symbols and required Botan version for PQC again and obsolete this PR. It might take a few weeks.

@ni4
Copy link
Contributor

ni4 commented Oct 1, 2024

@TJ-91 Yeah, feel free to close this. Codecov stuff should be fix itself once PR #2277 is merged.

@TJ-91 TJ-91 closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Botan's "warning: 'Kyber1024' is deprecated"
2 participants