Skip to content

Commit

Permalink
Fix: only set aws tokens if a key is specified
Browse files Browse the repository at this point in the history
laravel/framework#53633 fixes laravel side here but it won't be patched into older versions
  • Loading branch information
robchett authored Nov 22, 2024
1 parent 39508e0 commit df8353b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/BrefServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ private function fixAwsCredentialsConfig(): void
continue;
}
// If a different key is in the config than in the environment variables
if (isset($connection['key']) && $connection['key'] !== $accessKeyId) {
if (!isset($connection['key']) || $connection['key'] !== $accessKeyId) {
continue;
}

Expand All @@ -175,7 +175,7 @@ private function fixAwsCredentialsConfig(): void
continue;
}
// If a different key is in the config than in the environment variables
if (isset($disk['key']) && $disk['key'] !== $accessKeyId) {
if (!isset($disk['key']) || $disk['key'] !== $accessKeyId) {
continue;
}

Expand All @@ -188,7 +188,7 @@ private function fixAwsCredentialsConfig(): void
continue;
}
// If a different key is in the config than in the environment variables
if (isset($store['key']) && $store['key'] !== $accessKeyId) {
if (!isset($store['key']) || $store['key'] !== $accessKeyId) {
continue;
}

Expand Down

0 comments on commit df8353b

Please sign in to comment.