Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust default thread count on Apple Silicon systems #342

Open
robertknight opened this issue Sep 2, 2024 · 1 comment
Open

Adjust default thread count on Apple Silicon systems #342

robertknight opened this issue Sep 2, 2024 · 1 comment
Labels
performance Issues that affect model inference or loading performance

Comments

@robertknight
Copy link
Owner

Testing this whisper demo on an M-series MacBook Pro with 5 performance cores and 6 efficiency cores I found that the performance improved when increasing RTEN_NUM_THREADS up to 5 and then started to drop.

RTen currently defaults to using a number of threads that matches the number of physical cores without consideration of whether the cores are all the same or a mix of performance/efficiency. I have also been doing most testing on systems with 4 or fewer physical cores, so there might be contention issues that come up into play with more.
@robertknight robertknight added the performance Issues that affect model inference or loading performance label Sep 3, 2024
@robertknight
Copy link
Owner Author

See also seanmonstar/num_cpus#104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Issues that affect model inference or loading performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertknight