Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden files are not included in zip #10

Open
Mariopdel94 opened this issue Aug 15, 2021 · 5 comments
Open

Hidden files are not included in zip #10

Mariopdel94 opened this issue Aug 15, 2021 · 5 comments

Comments

@Mariopdel94
Copy link

Files starting with a . are not included in the zip folder.

Steps to reproduce

  • Create dist folder, add a bunch of files to be zipped.
  • Run echo unsafe-perm=true > dist/.npmrc
  • npm-build-zip --source=dist/ --destination=./ --name=dist --info=true
  • Unzip the new created folder.
  • .npmrc file is not included
@gilmorem560
Copy link

gilmorem560 commented Aug 19, 2021

Does this seem to only be hidden Unix files in the root of --source? I'm currently using this plugin to package a Greasemonkey plugin and it seems to copy the path/.gm.json file that I include along, but that is nested one directory deep. Additionally, which operating system are you trying this on?

@Mariopdel94
Copy link
Author

I'm using Windows 10

Yes it is for hidden files in --source, I didn't tested it for subfolders.

@gilmorem560
Copy link

gilmorem560 commented Aug 19, 2021

So the two possibilities I see are either including hidden Unix files on Windows doesn't work or including hidden Unix files in the root doesn't work. I'd advise clearing up this discrepancy, and hopefully upstream can fix it up. If I find some time in the coming days and there's no movement from upstream, I've got a fork I'm tidying some other stuff up in, I can take a crack at a fix for this too.

@gilmorem560
Copy link

Sorry, haven't had an opportunity to take a look again yet, but the fixes shouldn't be that hard....is upstream monitoring this at all???

@gilmorem560
Copy link

Hah, yeah I never got back around to this. Any word on whether this was a hidden files on Windows or hidden files in the root source folder issue? Can't say I've looked at it, but am in a position to do so these days if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants