Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name of the unzipped folder is different for some repos #743

Open
ningyougang opened this issue Jun 26, 2024 · 3 comments
Open

The name of the unzipped folder is different for some repos #743

ningyougang opened this issue Jun 26, 2024 · 3 comments

Comments

@ningyougang
Copy link

ningyougang commented Jun 26, 2024

I used release-downloader in our local with this tag: https://github.com/robinraju/release-downloader/commits/v1.8

Let's assume there has two repos

  • organization1/repo1
  • organization2/repo2

After downloaded, the name of the unzipped folder is different, e.g.

  • organization1/repo1
    • the unzipped folder: organization1-repo1-493ff260f81aeea194227538569ca9935de260fd
  • organization2/repo2
    • the unzipped folder: organization2-repo2-efa4cd0

The repo2's folder name just has 7 digits of the whole sha, someone knows the reason?

I hope organization2/repo2's unzipped folder is organization2-repo2-efa4cd07bd0195e6cc65e9e30c251b49ce4d3e51 rather than organization2-repo2-efa4cd0

@robinraju
Copy link
Owner

Is there any reason for using version 1.8? Have you tried the latest version of this action?

@ningyougang
Copy link
Author

ningyougang commented Jul 1, 2024

@robinraju ,

Thank you for your reply

Our commany forked this repo using v1.8 version, because for different scenes with same version(v1.8), there has different result, some repos use organization1-repo1-efa4cd0 this style, some repos use organization1-repo1-493ff260f81aeea194227538569ca9935de260fd style.

So i think it is not version issue.

Maybe somewhere to get the commitId, but i did not find where to get the commitId.

@robinraju
Copy link
Owner

Are you using the extract option provided by the action extract: true ? or manually extracting the file?

Can you copy the workflow step here?

AFAIK, The extract operation doesn't control the directory name. It extracts the contents as it is.
Also, we changed the underlying library used for extracting zip files in version 1.10 due to a bug.
#689

I suggest trying the latest version either by updating your forked version or use this action directly.

As an additional step check the process which creates the zip file and verify the zip file contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants