Default value for has_xpath_value #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than empty strings
…_default" so from a users point of view the has_xpath_value helper works like normal Moose attribute helpers with defaults
|
@ivanwills Sorry for the extremely long wait for a response on this PR. I've looked into it a bit, and the test to validate this code is quite hard to understand. Can you try to simplify it, so it's a bit more obvious what you're testing? Also, are you trying to store the default you want in the XML file or in the perl code that uses XML::Rabbit? The intent is not clear from the code and documentation you've included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to set a default value for the has_xpath_value attribute helper. This is required by some features in XMLSchema documents.