From 3b938e261adc3a9a55053b04950f5c468c61100e Mon Sep 17 00:00:00 2001 From: luketeam5 Date: Sat, 18 Jan 2025 18:29:47 +0100 Subject: [PATCH 1/4] Fixed incorrect type --- include/customDefinitions.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/customDefinitions.d.ts b/include/customDefinitions.d.ts index a145c45cb..7a9b59b4e 100644 --- a/include/customDefinitions.d.ts +++ b/include/customDefinitions.d.ts @@ -1132,7 +1132,7 @@ interface TextChannel extends Instance { interface TextChatService extends Instance { /** @client */ - OnBubbleAdded: (message: TextChatMessage, adornee: Instance) => TextChatMessageProperties | undefined; + OnBubbleAdded: (message: TextChatMessage, adornee: Instance) => BubbleChatMessageProperties | undefined; /** @client */ OnIncomingMessage: (message: TextChatMessage) => TextChatMessageProperties | undefined; } From c438ce7c4d188993045e5dbb97aa8a06193d3d28 Mon Sep 17 00:00:00 2001 From: luketeam5 Date: Mon, 20 Jan 2025 16:55:15 +0100 Subject: [PATCH 2/4] fix: added missing tuple for AddUserAsync --- include/customDefinitions.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/customDefinitions.d.ts b/include/customDefinitions.d.ts index 7a9b59b4e..2e448d2b9 100644 --- a/include/customDefinitions.d.ts +++ b/include/customDefinitions.d.ts @@ -1128,6 +1128,8 @@ interface TextChannel extends Instance { OnIncomingMessage: (message: TextChatMessage) => TextChatMessageProperties | undefined; /** @server */ ShouldDeliverCallback: (message: TextChatMessage, textSource: TextSource) => boolean; + /** @server */ + AddUserAsync(this: TextChannel, userId: number): [TextSource | undefined, boolean]; } interface TextChatService extends Instance { From 9dc095d2aadcb25dd8272c81654fa394bc25c3b5 Mon Sep 17 00:00:00 2001 From: luketeam5 Date: Wed, 22 Jan 2025 00:27:23 +0100 Subject: [PATCH 3/4] Update include/customDefinitions.d.ts Co-authored-by: Dion <39664950+Dionysusnu@users.noreply.github.com> --- include/customDefinitions.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/customDefinitions.d.ts b/include/customDefinitions.d.ts index 2e448d2b9..22bed3944 100644 --- a/include/customDefinitions.d.ts +++ b/include/customDefinitions.d.ts @@ -1129,7 +1129,7 @@ interface TextChannel extends Instance { /** @server */ ShouldDeliverCallback: (message: TextChatMessage, textSource: TextSource) => boolean; /** @server */ - AddUserAsync(this: TextChannel, userId: number): [TextSource | undefined, boolean]; + AddUserAsync(this: TextChannel, userId: number): [source: TextSource, isNew: true] | [source: TextSource, isNew: false] | [source: undefined, isNew: false]; } interface TextChatService extends Instance { From 9852d8f1603e3fe6986f06b442a1d22fdd4d597d Mon Sep 17 00:00:00 2001 From: luketeam5 Date: Wed, 22 Jan 2025 18:57:46 +0100 Subject: [PATCH 4/4] fix lint crying --- include/customDefinitions.d.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/customDefinitions.d.ts b/include/customDefinitions.d.ts index 22bed3944..f401f7ef1 100644 --- a/include/customDefinitions.d.ts +++ b/include/customDefinitions.d.ts @@ -1129,7 +1129,10 @@ interface TextChannel extends Instance { /** @server */ ShouldDeliverCallback: (message: TextChatMessage, textSource: TextSource) => boolean; /** @server */ - AddUserAsync(this: TextChannel, userId: number): [source: TextSource, isNew: true] | [source: TextSource, isNew: false] | [source: undefined, isNew: false]; + AddUserAsync( + this: TextChannel, + userId: number, + ): [source: TextSource, isNew: true] | [source: TextSource, isNew: false] | [source: undefined, isNew: false]; } interface TextChatService extends Instance {