Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the CAN monitor configuration inside the embot_app_eth_theBATservice #454

Closed
3 tasks done
valegagge opened this issue Dec 27, 2023 · 8 comments
Closed
3 tasks done
Assignees

Comments

@valegagge
Copy link
Member

valegagge commented Dec 27, 2023

This issue follows the #445 task.

As explained here #445 (comment), we need to use a default configuration if the sent configuration is empty.

Dod

  • The above-mentioned check has been implemented
  • The entire feature is tested on the robot.
  • the PR of the robot's configuration is ready. In this PR the battery board needs the address 2 and the templates files are updated.(See here Make the BAT compliant with the FW update #445 (comment) for more details)
@MSECode
Copy link
Contributor

MSECode commented Dec 28, 2023

Some of the improvements have been done. Specifically we have that:

  • update the battery configuration files setting the CAN address to 2 and the PR is ready here: Feature/fw updater bat robots-configuration#603
  • in the firmware we have added the check on the canmonitor checkPeriod and if equal to zero, meaning not set, we are setting it to 250 so that it is lower than the max value, which is 254 being a uint8 datatype, and greater than the transmission rate of the bat which is 100 ms. Here the PR with the changes: Feature/fw updater bat #447

@MSECode
Copy link
Contributor

MSECode commented Jan 4, 2024

Tested current improvements pushed to the branches linked above on ergoCub robot and here the screen:
MicrosoftTeams-image (2)

@MSECode
Copy link
Contributor

MSECode commented Jan 4, 2024

As you can see the BAT is sending correctly the messages when the YRI is started and no weird error is streamed on the YRI. (A couple of restarts have been done) and setting the check of the canmonitor at 250ms we have no error related to it continuosly printed on the YRI.

@MSECode
Copy link
Contributor

MSECode commented Jan 5, 2024

CAN Frames and stop and start transmission message between frames

image

@MSECode
Copy link
Contributor

MSECode commented Jan 9, 2024

All the PRs are here:

@MSECode
Copy link
Contributor

MSECode commented Jan 9, 2024

cc: @valegagge

@valegagge
Copy link
Member Author

it is also necessary the PR robotology/robots-configuration#603

@MSECode
Copy link
Contributor

MSECode commented Jan 10, 2024

PR closed --> moving to close state

@MSECode MSECode closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants