Fix SortCompilationUnitElementsTests.test012

Signed-off-by: Rob Stryker <[email protected]>
robstryker · Mar 26, 2024 · abe8942 · abe8942
1 parent a8b2a67
commit abe8942
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacConverter.java b/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacConverter.java
@@ -474,14 +474,19 @@ private MethodDeclaration convertMethodDecl(JCMethodDecl javac, ASTNode parent)
 		String javacName = javac.getName().toString();
 		String methodDeclName = getMethodDeclName(javac, parent);
 		boolean methodDeclNameMatchesInit = Objects.equals(methodDeclName, Names.instance(this.context).init.toString());
-		boolean javacNameMatchesInitAndMethodNameMatchesTypeName = javacName.equals("<init>") && methodDeclName.equals(getNodeName(parent));
+		boolean javacNameMatchesInit = javacName.equals("<init>");
+		boolean javacNameMatchesInitAndMethodNameMatchesTypeName = javacNameMatchesInit && methodDeclName.equals(getNodeName(parent));
 		boolean isConstructor = methodDeclNameMatchesInit || javacNameMatchesInitAndMethodNameMatchesTypeName;
 
 		res.setConstructor(isConstructor);
 		boolean malformed = false;
 		if(isConstructor && !javacNameMatchesInitAndMethodNameMatchesTypeName) {
 			malformed = true;
 		}
+		if( javacNameMatchesInit && !isConstructor ) {
+			malformed = true;
+		}
+
 		if( malformed ) {
 			res.setFlags(res.getFlags() | ASTNode.MALFORMED);
 		}